greg
/
nix-bitcoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

treewide: use TODO-EXTERNAL 

Use TODO-EXTERNAL for TODOs that depend on external factors like
upstream fixes.
This commit is contained in:
Erik Arvstedt 2021-11-28 21:36:04 +01:00
parent 6f37bef2a3
commit def64a73b8
No known key found for this signature in database
GPG Key ID: 33312B944DD97846
4 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/netns-isolation.nix
View File

@ -70,7 +70,8 @@ let
# and # and
# availableNetns.clighting = [ "bitcoind" ]; # availableNetns.clighting = [ "bitcoind" ];
# #
# FIXME: Although negligible for our purposes, this calculation's runtime # TODO-EXTERNAL:
# Although negligible for our purposes, this calculation's runtime
# is in the order of (number of connections * number of services), # is in the order of (number of connections * number of services),
# because attrsets and lists are fully copied on each update with '//' or '++'. # because attrsets and lists are fully copied on each update with '//' or '++'.
# This can only be improved with an update in the nix language. # This can only be improved with an update in the nix language.

2
modules/nix-bitcoin.nix
View File

@ -35,7 +35,7 @@ with lib;
runAsUserCmd = mkOption { runAsUserCmd = mkOption {
readOnly = true; readOnly = true;
default = if config.security.doas.enable default = if config.security.doas.enable
# TODO: Use absolute path until https://github.com/NixOS/nixpkgs/pull/133622 is available. # TODO-EXTERNAL: Use absolute path until https://github.com/NixOS/nixpkgs/pull/133622 is available.
then "/run/wrappers/bin/doas -u" then "/run/wrappers/bin/doas -u"
else "sudo -u"; else "sudo -u";
}; };

1
modules/presets/enable-tor.nix
View File

@ -23,6 +23,7 @@ in {
lnd = defaultEnableTorProxy; lnd = defaultEnableTorProxy;
lightning-loop = defaultEnableTorProxy; lightning-loop = defaultEnableTorProxy;
liquidd = defaultEnableTorProxy; liquidd = defaultEnableTorProxy;
# TODO-EXTERNAL:
# disable Tor enforcement until btcpayserver can fetch rates over Tor # disable Tor enforcement until btcpayserver can fetch rates over Tor
# btcpayserver = defaultEnableTorProxy; # btcpayserver = defaultEnableTorProxy;
spark-wallet = defaultEnableTorProxy; spark-wallet = defaultEnableTorProxy;

2
pkgs/python-packages/pyln-bolt7/default.nix
View File

@ -13,7 +13,7 @@ buildPythonPackage rec {
postUnpack = "sourceRoot=$sourceRoot/contrib/pyln-spec/bolt7"; postUnpack = "sourceRoot=$sourceRoot/contrib/pyln-spec/bolt7";
# TODO-EXTERNAL # TODO-EXTERNAL:
# Remove when this fix is released # Remove when this fix is released
# https://github.com/ElementsProject/lightning/pull/4910 # https://github.com/ElementsProject/lightning/pull/4910
postPatch = '' postPatch = ''