greg/nix-bitcoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lightning-loop regtest: fix incorrectly succeeding test

Browse Source 
When 'loop getparams' fails, jq gets no stdin and exits with code 0.
Because -o pipefail is not enabled in the testing shell, the whole test
command succeeds, although it should fail.

Just test "loop getparams" instead and ignore its output.
This commit is contained in:
Erik Arvstedt 2020-10-29 21:20:35 +01:00
parent e66636ef0e
commit 9ddf7864a4
No known key found for this signature in database
GPG Key ID: 33312B944DD97846
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/tests.py
View File

@ -337,7 +337,7 @@ def _():
machine.wait_until_succeeds( machine.wait_until_succeeds(
log_has_string("lightning-loop", "Starting event loop at height 10") log_has_string("lightning-loop", "Starting event loop at height 10")
) )
succeed("sudo -u operator loop getparams | jq -e '.rules'") succeed("sudo -u operator loop getparams")
if "netns-isolation" in enabled_tests: if "netns-isolation" in enabled_tests: