From 992c6943da90c9b0e421e5d2f25e24d699f1fa02 Mon Sep 17 00:00:00 2001
From: Greg Shuflin <greg@everydayimshuflin.com>
Date: Sun, 8 Oct 2023 20:47:20 -0700
Subject: [PATCH] Allow unstable features to be enabled with environment
 variable (#1588)

---
 README.md         |  3 ++-
 src/config.rs     |  7 ++++++-
 tests/lib.rs      |  1 +
 tests/test.rs     |  2 +-
 tests/unstable.rs | 50 +++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 60 insertions(+), 3 deletions(-)
 create mode 100644 tests/unstable.rs

diff --git a/README.md b/README.md
index 0725e28..928c59f 100644
--- a/README.md
+++ b/README.md
@@ -325,7 +325,8 @@ This does not, however, preclude fixing outright bugs, even if doing so might br
 
 There will never be a `just` 2.0. Any desirable backwards-incompatible changes will be opt-in on a per-`justfile` basis, so users may migrate at their leisure.
 
-Features that aren't yet ready for stabilization are gated behind the `--unstable` flag. Features enabled by `--unstable` may change in backwards incompatible ways at any time.
+Features that aren't yet ready for stabilization are gated behind the `--unstable` flag. Features enabled by `--unstable` may change in backwards incompatible ways at any time. Unstable features can also be enabled by setting the environment variable `JUST_UNSTABLE` to any value other than `false`, `0`, or the empty string.
+
 
 Editor Support
 --------------
diff --git a/src/config.rs b/src/config.rs
index 70cb43f..14904c5 100644
--- a/src/config.rs
+++ b/src/config.rs
@@ -569,6 +569,11 @@ impl Config {
       None
     };
 
+    let unstable = matches.is_present(arg::UNSTABLE)
+      || std::env::var_os("JUST_UNSTABLE")
+        .map(|val| !(val == "false" || val == "0" || val.is_empty()))
+        .unwrap_or_default();
+
     Ok(Self {
       check: matches.is_present(arg::CHECK),
       dry_run: matches.is_present(arg::DRY_RUN),
@@ -578,7 +583,7 @@ impl Config {
       load_dotenv: !matches.is_present(arg::NO_DOTENV),
       shell_command: matches.is_present(arg::SHELL_COMMAND),
       unsorted: matches.is_present(arg::UNSORTED),
-      unstable: matches.is_present(arg::UNSTABLE),
+      unstable,
       list_heading: matches
         .value_of(arg::LIST_HEADING)
         .unwrap_or("Available recipes:\n")
diff --git a/tests/lib.rs b/tests/lib.rs
index 6f119d0..37b1aff 100644
--- a/tests/lib.rs
+++ b/tests/lib.rs
@@ -87,6 +87,7 @@ mod string;
 mod subsequents;
 mod tempdir;
 mod undefined_variables;
+mod unstable;
 #[cfg(target_family = "windows")]
 mod windows_shell;
 mod working_directory;
diff --git a/tests/test.rs b/tests/test.rs
index 6c86f0a..e8dc786 100644
--- a/tests/test.rs
+++ b/tests/test.rs
@@ -234,7 +234,7 @@ impl Test {
 
     if let Some(ref stdout_regex) = self.stdout_regex {
       if !stdout_regex.is_match(output_stdout) {
-        panic!("Stdout regex mismatch:\n{output_stderr:?}\n!~=\n/{stdout_regex:?}/");
+        panic!("Stdout regex mismatch:\n{output_stdout:?}\n!~=\n/{stdout_regex:?}/");
       }
     }
 
diff --git a/tests/unstable.rs b/tests/unstable.rs
new file mode 100644
index 0000000..23a5fa6
--- /dev/null
+++ b/tests/unstable.rs
@@ -0,0 +1,50 @@
+use super::*;
+
+#[test]
+fn set_unstable_true_with_env_var() {
+  let justfile = r#"
+default:
+    echo 'foo'
+  "#;
+
+  for val in ["true", "some-arbitrary-string"] {
+    Test::new()
+      .justfile(justfile)
+      .args(["--fmt"])
+      .env("JUST_UNSTABLE", val)
+      .status(EXIT_SUCCESS)
+      .stderr_regex("Wrote justfile to `.*`\n")
+      .run();
+  }
+}
+
+#[test]
+fn set_unstable_false_with_env_var() {
+  let justfile = r#"
+default:
+    echo 'foo'
+  "#;
+  for val in ["0", "", "false"] {
+    Test::new()
+    .justfile(justfile)
+    .args(["--fmt"])
+    .env("JUST_UNSTABLE", val)
+    .status(EXIT_FAILURE)
+    .stderr("error: The `--fmt` command is currently unstable. Invoke `just` with the `--unstable` flag to enable unstable features.\n")
+    .run();
+  }
+}
+
+#[test]
+fn set_unstable_false_with_env_var_unset() {
+  let justfile = r#"
+default:
+    echo 'foo'
+  "#;
+  Test::new()
+    .justfile(justfile)
+    .args(["--fmt"])
+    .status(EXIT_FAILURE)
+    .stderr("error: The `--fmt` command is currently unstable. Invoke `just` with the `--unstable` flag to enable unstable features.\n")
+    .run();
+}