Gargantuan refactor (#522)
- Instead of changing the current directory with `env::set_current_dir`
to be implicitly inherited by subprocesses, we now use
`Command::current_dir` to set it explicitly. This feels much better,
since we aren't dependent on the implicit state of the process's
current directory.
- Subcommand execution is much improved.
- Added a ton of tests for config parsing, config execution, working
dir, and search dir.
- Error messages are improved. Many more will be colored.
- The Config is now onwed, instead of borrowing from the arguments and
the `clap::ArgMatches` object. This is a huge ergonomic improvement,
especially in tests, and I don't think anyone will notice.
- `--edit` now uses `$VISUAL`, `$EDITOR`, or `vim`, in that order,
matching git, which I think is what most people will expect.
- Added a cute `tmptree!{}` macro, for creating temporary directories
populated with directories and files for tests.
- Admitted that grammer is LL(k) and I don't know what `k` is.
2019-11-09 21:43:20 -08:00
|
|
|
use crate::common::*;
|
|
|
|
|
2021-07-26 01:26:06 -07:00
|
|
|
#[derive(Debug)]
|
|
|
|
pub(crate) enum Error<'src> {
|
|
|
|
ArgumentCountMismatch {
|
|
|
|
recipe: &'src str,
|
|
|
|
parameters: Vec<Parameter<'src>>,
|
|
|
|
found: usize,
|
|
|
|
min: usize,
|
|
|
|
max: usize,
|
|
|
|
},
|
|
|
|
Backtick {
|
|
|
|
token: Token<'src>,
|
|
|
|
output_error: OutputError,
|
|
|
|
},
|
|
|
|
ChooserInvoke {
|
|
|
|
shell_binary: String,
|
|
|
|
shell_arguments: String,
|
|
|
|
chooser: OsString,
|
|
|
|
io_error: io::Error,
|
|
|
|
},
|
|
|
|
ChooserRead {
|
|
|
|
chooser: OsString,
|
|
|
|
io_error: io::Error,
|
|
|
|
},
|
|
|
|
ChooserStatus {
|
|
|
|
chooser: OsString,
|
|
|
|
status: ExitStatus,
|
|
|
|
},
|
|
|
|
ChooserWrite {
|
|
|
|
chooser: OsString,
|
|
|
|
io_error: io::Error,
|
|
|
|
},
|
|
|
|
Code {
|
|
|
|
recipe: &'src str,
|
|
|
|
line_number: Option<usize>,
|
|
|
|
code: i32,
|
|
|
|
},
|
|
|
|
CommandInvoke {
|
|
|
|
binary: OsString,
|
|
|
|
arguments: Vec<OsString>,
|
|
|
|
io_error: io::Error,
|
|
|
|
},
|
|
|
|
CommandStatus {
|
|
|
|
binary: OsString,
|
|
|
|
arguments: Vec<OsString>,
|
|
|
|
status: ExitStatus,
|
|
|
|
},
|
|
|
|
Compile {
|
|
|
|
compile_error: CompileError<'src>,
|
|
|
|
},
|
|
|
|
Config {
|
|
|
|
config_error: ConfigError,
|
|
|
|
},
|
|
|
|
Cygpath {
|
|
|
|
recipe: &'src str,
|
|
|
|
output_error: OutputError,
|
|
|
|
},
|
|
|
|
DefaultRecipeRequiresArguments {
|
|
|
|
recipe: &'src str,
|
|
|
|
min_arguments: usize,
|
|
|
|
},
|
|
|
|
Dotenv {
|
|
|
|
dotenv_error: dotenv::Error,
|
|
|
|
},
|
|
|
|
EditorInvoke {
|
|
|
|
editor: OsString,
|
|
|
|
io_error: io::Error,
|
|
|
|
},
|
|
|
|
EditorStatus {
|
|
|
|
editor: OsString,
|
|
|
|
status: ExitStatus,
|
|
|
|
},
|
|
|
|
EvalUnknownVariable {
|
|
|
|
variable: String,
|
|
|
|
suggestion: Option<Suggestion<'src>>,
|
|
|
|
},
|
|
|
|
FunctionCall {
|
|
|
|
function: Name<'src>,
|
|
|
|
message: String,
|
|
|
|
},
|
|
|
|
InitExists {
|
|
|
|
justfile: PathBuf,
|
|
|
|
},
|
|
|
|
Internal {
|
|
|
|
message: String,
|
|
|
|
},
|
|
|
|
Io {
|
|
|
|
recipe: &'src str,
|
|
|
|
io_error: io::Error,
|
|
|
|
},
|
|
|
|
Load {
|
|
|
|
path: PathBuf,
|
|
|
|
io_error: io::Error,
|
|
|
|
},
|
|
|
|
NoChoosableRecipes,
|
|
|
|
NoRecipes,
|
|
|
|
Search {
|
|
|
|
search_error: SearchError,
|
|
|
|
},
|
|
|
|
Shebang {
|
|
|
|
recipe: &'src str,
|
|
|
|
command: String,
|
|
|
|
argument: Option<String>,
|
|
|
|
io_error: io::Error,
|
|
|
|
},
|
|
|
|
Signal {
|
|
|
|
recipe: &'src str,
|
|
|
|
line_number: Option<usize>,
|
|
|
|
signal: i32,
|
|
|
|
},
|
|
|
|
TmpdirIo {
|
|
|
|
recipe: &'src str,
|
|
|
|
io_error: io::Error,
|
|
|
|
},
|
|
|
|
Unknown {
|
|
|
|
recipe: &'src str,
|
|
|
|
line_number: Option<usize>,
|
|
|
|
},
|
|
|
|
UnknownOverrides {
|
|
|
|
overrides: Vec<String>,
|
|
|
|
},
|
|
|
|
UnknownRecipes {
|
|
|
|
recipes: Vec<String>,
|
|
|
|
suggestion: Option<Suggestion<'src>>,
|
|
|
|
},
|
|
|
|
Unstable {
|
|
|
|
message: String,
|
|
|
|
},
|
|
|
|
WriteJustfile {
|
|
|
|
justfile: PathBuf,
|
|
|
|
io_error: io::Error,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'src> Error<'src> {
|
|
|
|
pub(crate) fn code(&self) -> Option<i32> {
|
|
|
|
match self {
|
|
|
|
Self::Code { code, .. }
|
|
|
|
| Self::Backtick {
|
|
|
|
output_error: OutputError::Code(code),
|
|
|
|
..
|
|
|
|
} => Some(*code),
|
|
|
|
Self::ChooserStatus { status, .. } | Self::EditorStatus { status, .. } => status.code(),
|
|
|
|
_ => None,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn context(&self) -> Option<Token<'src>> {
|
|
|
|
match self {
|
|
|
|
Self::Backtick { token, .. } => Some(*token),
|
|
|
|
Self::Compile { compile_error } => Some(compile_error.context()),
|
|
|
|
Self::FunctionCall { function, .. } => Some(function.token()),
|
|
|
|
_ => None,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
pub(crate) fn internal(message: impl Into<String>) -> Self {
|
|
|
|
Self::Internal {
|
|
|
|
message: message.into(),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'src> From<CompileError<'src>> for Error<'src> {
|
|
|
|
fn from(compile_error: CompileError<'src>) -> Self {
|
|
|
|
Self::Compile { compile_error }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'src> From<ConfigError> for Error<'src> {
|
|
|
|
fn from(config_error: ConfigError) -> Self {
|
|
|
|
Self::Config { config_error }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'src> From<dotenv::Error> for Error<'src> {
|
|
|
|
fn from(dotenv_error: dotenv::Error) -> Error<'src> {
|
|
|
|
Self::Dotenv { dotenv_error }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'src> From<SearchError> for Error<'src> {
|
|
|
|
fn from(search_error: SearchError) -> Self {
|
|
|
|
Self::Search { search_error }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-07-28 18:06:57 -07:00
|
|
|
impl<'src> ColorDisplay for Error<'src> {
|
|
|
|
fn fmt(&self, f: &mut Formatter, color: Color) -> fmt::Result {
|
2021-07-26 01:26:06 -07:00
|
|
|
use Error::*;
|
|
|
|
|
2021-07-28 18:06:57 -07:00
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"{}: {}",
|
|
|
|
color.error().paint("error"),
|
|
|
|
color.message().prefix()
|
|
|
|
)?;
|
|
|
|
|
2021-07-26 01:26:06 -07:00
|
|
|
match self {
|
|
|
|
ArgumentCountMismatch {
|
|
|
|
recipe,
|
|
|
|
found,
|
|
|
|
min,
|
|
|
|
max,
|
2021-07-28 18:27:47 -07:00
|
|
|
..
|
|
|
|
} =>
|
2021-07-26 01:26:06 -07:00
|
|
|
if min == max {
|
|
|
|
let expected = min;
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` got {} {} but {}takes {}",
|
|
|
|
recipe,
|
|
|
|
found,
|
|
|
|
Count("argument", *found),
|
|
|
|
if expected < found { "only " } else { "" },
|
|
|
|
expected
|
|
|
|
)?;
|
|
|
|
} else if found < min {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` got {} {} but takes at least {}",
|
|
|
|
recipe,
|
|
|
|
found,
|
|
|
|
Count("argument", *found),
|
|
|
|
min
|
|
|
|
)?;
|
|
|
|
} else if found > max {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` got {} {} but takes at most {}",
|
|
|
|
recipe,
|
|
|
|
found,
|
|
|
|
Count("argument", *found),
|
|
|
|
max
|
|
|
|
)?;
|
2021-07-28 18:27:47 -07:00
|
|
|
},
|
2021-07-26 01:26:06 -07:00
|
|
|
Backtick { output_error, .. } => match output_error {
|
|
|
|
OutputError::Code(code) => {
|
|
|
|
write!(f, "Backtick failed with exit code {}", code)?;
|
|
|
|
},
|
|
|
|
OutputError::Signal(signal) => {
|
|
|
|
write!(f, "Backtick was terminated by signal {}", signal)?;
|
|
|
|
},
|
|
|
|
OutputError::Unknown => {
|
|
|
|
write!(f, "Backtick failed for an unknown reason")?;
|
|
|
|
},
|
|
|
|
OutputError::Io(io_error) => {
|
|
|
|
match io_error.kind() {
|
|
|
|
io::ErrorKind::NotFound => write!(
|
|
|
|
f,
|
|
|
|
"Backtick could not be run because just could not find `sh`:\n{}",
|
|
|
|
io_error
|
|
|
|
),
|
|
|
|
io::ErrorKind::PermissionDenied => write!(
|
|
|
|
f,
|
|
|
|
"Backtick could not be run because just could not run `sh`:\n{}",
|
|
|
|
io_error
|
|
|
|
),
|
|
|
|
_ => write!(
|
|
|
|
f,
|
|
|
|
"Backtick could not be run because of an IO error while launching `sh`:\n{}",
|
|
|
|
io_error
|
|
|
|
),
|
|
|
|
}?;
|
|
|
|
},
|
|
|
|
OutputError::Utf8(utf8_error) => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Backtick succeeded but stdout was not utf8: {}",
|
|
|
|
utf8_error
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
},
|
|
|
|
ChooserInvoke {
|
|
|
|
shell_binary,
|
|
|
|
shell_arguments,
|
|
|
|
chooser,
|
|
|
|
io_error,
|
|
|
|
} => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Chooser `{} {} {}` invocation failed: {}",
|
|
|
|
shell_binary,
|
|
|
|
shell_arguments,
|
|
|
|
chooser.to_string_lossy(),
|
|
|
|
io_error,
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
ChooserRead { chooser, io_error } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Failed to read output from chooser `{}`: {}",
|
|
|
|
chooser.to_string_lossy(),
|
|
|
|
io_error
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
ChooserStatus { chooser, status } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Chooser `{}` failed: {}",
|
|
|
|
chooser.to_string_lossy(),
|
|
|
|
status
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
ChooserWrite { chooser, io_error } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Failed to write to chooser `{}`: {}",
|
|
|
|
chooser.to_string_lossy(),
|
|
|
|
io_error
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
Code {
|
|
|
|
recipe,
|
|
|
|
line_number,
|
|
|
|
code,
|
|
|
|
} =>
|
|
|
|
if let Some(n) = line_number {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` failed on line {} with exit code {}",
|
|
|
|
recipe, n, code
|
|
|
|
)?;
|
|
|
|
} else {
|
|
|
|
write!(f, "Recipe `{}` failed with exit code {}", recipe, code)?;
|
|
|
|
},
|
|
|
|
CommandInvoke {
|
|
|
|
binary,
|
|
|
|
arguments,
|
|
|
|
io_error,
|
|
|
|
} => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Failed to invoke {}: {}",
|
|
|
|
iter::once(binary)
|
|
|
|
.chain(arguments)
|
|
|
|
.map(|value| Enclosure::tick(value.to_string_lossy()).to_string())
|
|
|
|
.collect::<Vec<String>>()
|
|
|
|
.join(" "),
|
|
|
|
io_error,
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
CommandStatus {
|
|
|
|
binary,
|
|
|
|
arguments,
|
|
|
|
status,
|
|
|
|
} => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Command {} failed: {}",
|
|
|
|
iter::once(binary)
|
|
|
|
.chain(arguments)
|
|
|
|
.map(|value| Enclosure::tick(value.to_string_lossy()).to_string())
|
|
|
|
.collect::<Vec<String>>()
|
|
|
|
.join(" "),
|
|
|
|
status,
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
Compile { compile_error } => Display::fmt(compile_error, f)?,
|
|
|
|
Config { config_error } => Display::fmt(config_error, f)?,
|
|
|
|
Cygpath {
|
|
|
|
recipe,
|
|
|
|
output_error,
|
|
|
|
} => match output_error {
|
|
|
|
OutputError::Code(code) => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Cygpath failed with exit code {} while translating recipe `{}` shebang interpreter \
|
|
|
|
path",
|
|
|
|
code, recipe
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
OutputError::Signal(signal) => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Cygpath terminated by signal {} while translating recipe `{}` shebang interpreter \
|
|
|
|
path",
|
|
|
|
signal, recipe
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
OutputError::Unknown => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Cygpath experienced an unknown failure while translating recipe `{}` shebang \
|
|
|
|
interpreter path",
|
|
|
|
recipe
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
OutputError::Io(io_error) => {
|
|
|
|
match io_error.kind() {
|
|
|
|
io::ErrorKind::NotFound => write!(
|
|
|
|
f,
|
|
|
|
"Could not find `cygpath` executable to translate recipe `{}` shebang interpreter \
|
|
|
|
path:\n{}",
|
|
|
|
recipe, io_error
|
|
|
|
),
|
|
|
|
io::ErrorKind::PermissionDenied => write!(
|
|
|
|
f,
|
|
|
|
"Could not run `cygpath` executable to translate recipe `{}` shebang interpreter \
|
|
|
|
path:\n{}",
|
|
|
|
recipe, io_error
|
|
|
|
),
|
|
|
|
_ => write!(f, "Could not run `cygpath` executable:\n{}", io_error),
|
|
|
|
}?;
|
|
|
|
},
|
|
|
|
OutputError::Utf8(utf8_error) => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Cygpath successfully translated recipe `{}` shebang interpreter path, but output was \
|
|
|
|
not utf8: {}",
|
|
|
|
recipe, utf8_error
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
},
|
|
|
|
DefaultRecipeRequiresArguments {
|
|
|
|
recipe,
|
|
|
|
min_arguments,
|
|
|
|
} => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` cannot be used as default recipe since it requires at least {} {}.",
|
|
|
|
recipe,
|
|
|
|
min_arguments,
|
|
|
|
Count("argument", *min_arguments),
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
Dotenv { dotenv_error } => {
|
|
|
|
write!(f, "Failed to load .env: {}", dotenv_error)?;
|
|
|
|
},
|
|
|
|
EditorInvoke { editor, io_error } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Editor `{}` invocation failed: {}",
|
|
|
|
editor.to_string_lossy(),
|
|
|
|
io_error
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
EditorStatus { editor, status } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Editor `{}` failed: {}",
|
|
|
|
editor.to_string_lossy(),
|
|
|
|
status
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
EvalUnknownVariable {
|
|
|
|
variable,
|
|
|
|
suggestion,
|
|
|
|
} => {
|
|
|
|
write!(f, "Justfile does not contain variable `{}`.", variable,)?;
|
|
|
|
if let Some(suggestion) = *suggestion {
|
|
|
|
write!(f, "\n{}", suggestion)?;
|
|
|
|
}
|
|
|
|
},
|
|
|
|
FunctionCall { function, message } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Call to function `{}` failed: {}",
|
|
|
|
function.lexeme(),
|
|
|
|
message
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
InitExists { justfile } => {
|
|
|
|
write!(f, "Justfile `{}` already exists", justfile.display())?;
|
|
|
|
},
|
|
|
|
Internal { message } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Internal runtime error, this may indicate a bug in just: {} \
|
|
|
|
consider filing an issue: https://github.com/casey/just/issues/new",
|
|
|
|
message
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
Io { recipe, io_error } => {
|
|
|
|
match io_error.kind() {
|
|
|
|
io::ErrorKind::NotFound => write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` could not be run because just could not find `sh`: {}",
|
|
|
|
recipe, io_error
|
|
|
|
),
|
|
|
|
io::ErrorKind::PermissionDenied => write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` could not be run because just could not run `sh`: {}",
|
|
|
|
recipe, io_error
|
|
|
|
),
|
|
|
|
_ => write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` could not be run because of an IO error while launching `sh`: {}",
|
|
|
|
recipe, io_error
|
|
|
|
),
|
|
|
|
}?;
|
|
|
|
},
|
|
|
|
Load { io_error, path } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Failed to read justfile at `{}`: {}",
|
|
|
|
path.display(),
|
|
|
|
io_error
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
NoChoosableRecipes => {
|
|
|
|
write!(f, "Justfile contains no choosable recipes.")?;
|
|
|
|
},
|
|
|
|
NoRecipes => {
|
|
|
|
write!(f, "Justfile contains no recipes.")?;
|
|
|
|
},
|
|
|
|
Search { search_error } => Display::fmt(search_error, f)?,
|
|
|
|
Shebang {
|
|
|
|
recipe,
|
|
|
|
command,
|
|
|
|
argument,
|
|
|
|
io_error,
|
|
|
|
} =>
|
|
|
|
if let Some(argument) = argument {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` with shebang `#!{} {}` execution error: {}",
|
|
|
|
recipe, command, argument, io_error
|
|
|
|
)?;
|
|
|
|
} else {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` with shebang `#!{}` execution error: {}",
|
|
|
|
recipe, command, io_error
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
Signal {
|
|
|
|
recipe,
|
|
|
|
line_number,
|
|
|
|
signal,
|
|
|
|
} =>
|
|
|
|
if let Some(n) = line_number {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` was terminated on line {} by signal {}",
|
|
|
|
recipe, n, signal
|
|
|
|
)?;
|
|
|
|
} else {
|
|
|
|
write!(f, "Recipe `{}` was terminated by signal {}", recipe, signal)?;
|
|
|
|
},
|
|
|
|
TmpdirIo { recipe, io_error } => write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` could not be run because of an IO error while trying to create a temporary \
|
|
|
|
directory or write a file to that directory`:{}",
|
|
|
|
recipe, io_error
|
|
|
|
)?,
|
|
|
|
Unknown {
|
|
|
|
recipe,
|
|
|
|
line_number,
|
|
|
|
} =>
|
|
|
|
if let Some(n) = line_number {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Recipe `{}` failed on line {} for an unknown reason",
|
|
|
|
recipe, n
|
|
|
|
)?;
|
|
|
|
} else {
|
|
|
|
write!(f, "Recipe `{}` failed for an unknown reason", recipe)?;
|
|
|
|
},
|
|
|
|
UnknownOverrides { overrides } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"{} {} overridden on the command line but not present in justfile",
|
|
|
|
Count("Variable", overrides.len()),
|
|
|
|
List::and_ticked(overrides),
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
UnknownRecipes {
|
|
|
|
recipes,
|
|
|
|
suggestion,
|
|
|
|
} => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Justfile does not contain {} {}.",
|
|
|
|
Count("recipe", recipes.len()),
|
|
|
|
List::or_ticked(recipes),
|
|
|
|
)?;
|
|
|
|
if let Some(suggestion) = *suggestion {
|
|
|
|
write!(f, "\n{}", suggestion)?;
|
|
|
|
}
|
|
|
|
},
|
|
|
|
Unstable { message } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"{} Invoke `just` with the `--unstable` flag to enable unstable features.",
|
|
|
|
message
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
WriteJustfile { justfile, io_error } => {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"Failed to write justfile to `{}`: {}",
|
|
|
|
justfile.display(),
|
|
|
|
io_error
|
|
|
|
)?;
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2021-07-28 18:06:57 -07:00
|
|
|
write!(f, "{}", color.message().suffix())?;
|
|
|
|
|
2021-07-28 18:27:47 -07:00
|
|
|
if let ArgumentCountMismatch {
|
|
|
|
recipe, parameters, ..
|
|
|
|
} = self
|
|
|
|
{
|
|
|
|
writeln!(f)?;
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"{}:\n just {}",
|
|
|
|
color.message().paint("usage"),
|
|
|
|
recipe
|
|
|
|
)?;
|
|
|
|
for param in parameters {
|
|
|
|
write!(f, " {}", param.color_display(color))?;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-07-28 18:06:57 -07:00
|
|
|
if let Some(token) = self.context() {
|
|
|
|
writeln!(f)?;
|
|
|
|
write!(f, "{}", token.color_display(color.error()))?;
|
|
|
|
}
|
|
|
|
|
2021-07-26 01:26:06 -07:00
|
|
|
Ok(())
|
Gargantuan refactor (#522)
- Instead of changing the current directory with `env::set_current_dir`
to be implicitly inherited by subprocesses, we now use
`Command::current_dir` to set it explicitly. This feels much better,
since we aren't dependent on the implicit state of the process's
current directory.
- Subcommand execution is much improved.
- Added a ton of tests for config parsing, config execution, working
dir, and search dir.
- Error messages are improved. Many more will be colored.
- The Config is now onwed, instead of borrowing from the arguments and
the `clap::ArgMatches` object. This is a huge ergonomic improvement,
especially in tests, and I don't think anyone will notice.
- `--edit` now uses `$VISUAL`, `$EDITOR`, or `vim`, in that order,
matching git, which I think is what most people will expect.
- Added a cute `tmptree!{}` macro, for creating temporary directories
populated with directories and files for tests.
- Admitted that grammer is LL(k) and I don't know what `k` is.
2019-11-09 21:43:20 -08:00
|
|
|
}
|
|
|
|
}
|