just/src/subcommand.rs

use crate::common::*;

#[derive(PartialEq, Clone, Debug)]
pub(crate) enum Subcommand {
  Dump,
  Edit,
  Evaluate {
    overrides: BTreeMap<String, String>,
  },
  Init,
  List,
  Run {
    overrides: BTreeMap<String, String>,
    arguments: Vec<String>,
  },
  Show {
    name: String,
  },
  Summary,
}
Reform positional argument parsing (#523) This diff makes positional argument parsing much cleaner, along with adding a bunch of tests. Just's positional argument parsing is rather, complex, so hopefully this reform allows it to both be correct and stay correct. User-visible changes: - `just ..` is now accepted, with the same effect as `just ../` - `just .` is also accepted, with the same effect as `just` - It is now an error to pass arguments or overrides to subcommands that do not accept them, namely `--dump`, `--edit`, `--list`, `--show`, and `--summary`. It is also an error to pass arguments to `--evaluate`, although `--evaluate` does of course still accept overrides. (This is a breaking change, but hopefully worth it, as it will allow us to add arguments to subcommands which did not previously take them, if we so desire.) - Subcommands which do not accept arguments may now accept a single search-directory argument, so `just --list ../` and `just --dump foo/` are now accepted, with the former starting the search for the justfile to list in the parent directory, and the latter starting the search for the justfile to dump in `foo`. 2019-11-10 18:02:36 -08:00			`use crate::common::*;`

Gargantuan refactor (#522) - Instead of changing the current directory with `env::set_current_dir` to be implicitly inherited by subprocesses, we now use `Command::current_dir` to set it explicitly. This feels much better, since we aren't dependent on the implicit state of the process's current directory. - Subcommand execution is much improved. - Added a ton of tests for config parsing, config execution, working dir, and search dir. - Error messages are improved. Many more will be colored. - The Config is now onwed, instead of borrowing from the arguments and the `clap::ArgMatches` object. This is a huge ergonomic improvement, especially in tests, and I don't think anyone will notice. - `--edit` now uses `$VISUAL`, `$EDITOR`, or `vim`, in that order, matching git, which I think is what most people will expect. - Added a cute `tmptree!{}` macro, for creating temporary directories populated with directories and files for tests. - Admitted that grammer is LL(k) and I don't know what `k` is. 2019-11-09 21:43:20 -08:00			`#[derive(PartialEq, Clone, Debug)]`
			`pub(crate) enum Subcommand {`
Add explicit `Subcommand` enum (#484) 2019-10-07 04:04:39 -07:00			`Dump,`
Use constants instead of literals in arg parser (#504) - Differentiate between `arg`s, which are flags and options, and `cmd`s, which are mutually exclusive subcommands - Replace string literals, like "EVALUATE", with constants, like `cmd::EVALUATE`, since they're slightly less error prone. - Remove `Config::evaluate`, and handle it like other subcommands 2019-10-31 17:39:25 -07:00			`Edit,`
Reform positional argument parsing (#523) This diff makes positional argument parsing much cleaner, along with adding a bunch of tests. Just's positional argument parsing is rather, complex, so hopefully this reform allows it to both be correct and stay correct. User-visible changes: - `just ..` is now accepted, with the same effect as `just ../` - `just .` is also accepted, with the same effect as `just` - It is now an error to pass arguments or overrides to subcommands that do not accept them, namely `--dump`, `--edit`, `--list`, `--show`, and `--summary`. It is also an error to pass arguments to `--evaluate`, although `--evaluate` does of course still accept overrides. (This is a breaking change, but hopefully worth it, as it will allow us to add arguments to subcommands which did not previously take them, if we so desire.) - Subcommands which do not accept arguments may now accept a single search-directory argument, so `just --list ../` and `just --dump foo/` are now accepted, with the former starting the search for the justfile to list in the parent directory, and the latter starting the search for the justfile to dump in `foo`. 2019-11-10 18:02:36 -08:00			`Evaluate {`
			`overrides: BTreeMap<String, String>,`
			`},`
Add `--init` subcommand (#541) When `--init` is passed on the command line, search upward for the project root, identified by the presence of a VCS directory like `.git`, falling back to the current directory, and create a default justfile in that directory. 2019-11-19 23:07:44 -08:00			`Init,`
			`List,`
Reform positional argument parsing (#523) This diff makes positional argument parsing much cleaner, along with adding a bunch of tests. Just's positional argument parsing is rather, complex, so hopefully this reform allows it to both be correct and stay correct. User-visible changes: - `just ..` is now accepted, with the same effect as `just ../` - `just .` is also accepted, with the same effect as `just` - It is now an error to pass arguments or overrides to subcommands that do not accept them, namely `--dump`, `--edit`, `--list`, `--show`, and `--summary`. It is also an error to pass arguments to `--evaluate`, although `--evaluate` does of course still accept overrides. (This is a breaking change, but hopefully worth it, as it will allow us to add arguments to subcommands which did not previously take them, if we so desire.) - Subcommands which do not accept arguments may now accept a single search-directory argument, so `just --list ../` and `just --dump foo/` are now accepted, with the former starting the search for the justfile to list in the parent directory, and the latter starting the search for the justfile to dump in `foo`. 2019-11-10 18:02:36 -08:00			`Run {`
			`overrides: BTreeMap<String, String>,`
			`arguments: Vec<String>,`
			`},`
			`Show {`
			`name: String,`
			`},`
Use constants instead of literals in arg parser (#504) - Differentiate between `arg`s, which are flags and options, and `cmd`s, which are mutually exclusive subcommands - Replace string literals, like "EVALUATE", with constants, like `cmd::EVALUATE`, since they're slightly less error prone. - Remove `Config::evaluate`, and handle it like other subcommands 2019-10-31 17:39:25 -07:00			`Summary,`
Add explicit `Subcommand` enum (#484) 2019-10-07 04:04:39 -07:00			`}`