Gargantuan refactor (#522)
- Instead of changing the current directory with `env::set_current_dir`
to be implicitly inherited by subprocesses, we now use
`Command::current_dir` to set it explicitly. This feels much better,
since we aren't dependent on the implicit state of the process's
current directory.
- Subcommand execution is much improved.
- Added a ton of tests for config parsing, config execution, working
dir, and search dir.
- Error messages are improved. Many more will be colored.
- The Config is now onwed, instead of borrowing from the arguments and
the `clap::ArgMatches` object. This is a huge ergonomic improvement,
especially in tests, and I don't think anyone will notice.
- `--edit` now uses `$VISUAL`, `$EDITOR`, or `vim`, in that order,
matching git, which I think is what most people will expect.
- Added a cute `tmptree!{}` macro, for creating temporary directories
populated with directories and files for tests.
- Admitted that grammer is LL(k) and I don't know what `k` is.
2019-11-09 21:43:20 -08:00
|
|
|
use crate::common::*;
|
|
|
|
|
|
|
|
pub(crate) trait ErrorResultExt<T> {
|
|
|
|
fn eprint(self, color: Color) -> Result<T, i32>;
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<T, E: Error> ErrorResultExt<T> for Result<T, E> {
|
|
|
|
fn eprint(self, color: Color) -> Result<T, i32> {
|
|
|
|
match self {
|
|
|
|
Ok(ok) => Ok(ok),
|
|
|
|
Err(error) => {
|
|
|
|
if color.stderr().active() {
|
2019-12-12 17:55:55 -08:00
|
|
|
eprintln!("{}: {:#}", color.stderr().error().paint("error"), error);
|
Gargantuan refactor (#522)
- Instead of changing the current directory with `env::set_current_dir`
to be implicitly inherited by subprocesses, we now use
`Command::current_dir` to set it explicitly. This feels much better,
since we aren't dependent on the implicit state of the process's
current directory.
- Subcommand execution is much improved.
- Added a ton of tests for config parsing, config execution, working
dir, and search dir.
- Error messages are improved. Many more will be colored.
- The Config is now onwed, instead of borrowing from the arguments and
the `clap::ArgMatches` object. This is a huge ergonomic improvement,
especially in tests, and I don't think anyone will notice.
- `--edit` now uses `$VISUAL`, `$EDITOR`, or `vim`, in that order,
matching git, which I think is what most people will expect.
- Added a cute `tmptree!{}` macro, for creating temporary directories
populated with directories and files for tests.
- Admitted that grammer is LL(k) and I don't know what `k` is.
2019-11-09 21:43:20 -08:00
|
|
|
} else {
|
|
|
|
eprintln!("error: {}", error);
|
|
|
|
}
|
|
|
|
|
|
|
|
Err(error.code())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|