greg/cpython
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

gh-106350: Tkinter: do not ignore return value of mp_init() (GH-106351)

Browse Source
This commit is contained in:
Christopher Chavez
2023-07-25 13:52:07 -05:00
committed by GitHub
parent 2b1a81e2cf
commit b5ae7c4984
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Misc/NEWS.d/next/Library/2023-07-03-03-46-20.gh-issue-106350.LLcTEe.rst Normal file
View File

@@ -0,0 +1,2 @@
Detect possible memory allocation failure in the libtommath function :c:func:`mp_init`
used by the ``_tkinter`` module.

5
Modules/_tkinter.c
View File

@@ -874,8 +874,9 @@ asBignumObj(PyObject *value)
return NULL; return NULL;
} }
hexchars += neg + 2; /* skip sign and "0x" */ hexchars += neg + 2; /* skip sign and "0x" */
mp_init(&bigValue); if (mp_init(&bigValue) != MP_OKAY ||
if (mp_read_radix(&bigValue, hexchars, 16) != MP_OKAY) { mp_read_radix(&bigValue, hexchars, 16) != MP_OKAY)
{
mp_clear(&bigValue); mp_clear(&bigValue);
Py_DECREF(hexstr); Py_DECREF(hexstr);
PyErr_NoMemory(); PyErr_NoMemory();