greg/cpython
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

gh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (GH-101615)

Browse Source
This commit is contained in:
David Hewitt
2023-02-08 14:23:57 +00:00
committed by GitHub
parent eb49d32b9a
commit 3a88de7a0a
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Misc/NEWS.d/next/Windows/2023-02-07-18-22-54.gh-issue-101614.NjVP0n.rst Normal file
View File

@@ -0,0 +1 @@
Correctly handle extensions built against debug binaries that reference ``python3_d.dll``.

9
Python/dynload_win.c
View File

@@ -125,14 +125,15 @@ static char *GetPythonImport (HINSTANCE hModule)
!strncmp(import_name,"python",6)) { !strncmp(import_name,"python",6)) {
char *pch; char *pch;
#ifndef _DEBUG /* Don't claim that python3.dll is a Python DLL. */
/* In a release version, don't claim that python3.dll is #ifdef _DEBUG
a Python DLL. */ if (strcmp(import_name, "python3_d.dll") == 0) {
#else
if (strcmp(import_name, "python3.dll") == 0) { if (strcmp(import_name, "python3.dll") == 0) {
#endif
import_data += 20; import_data += 20;
continue; continue;
} }
#endif
/* Ensure python prefix is followed only /* Ensure python prefix is followed only
by numbers to the end of the basename */ by numbers to the end of the basename */